-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for deploying and querying a prompt-tuned google/flan-t5-xl LLM #1272
Add test for deploying and querying a prompt-tuned google/flan-t5-xl LLM #1272
Conversation
- mountPath: "/mnt/prompts/" | ||
name: model-volume | ||
containers: | ||
- name: download-model-prompts |
Check warning
Code scanning / SonarCloud
CPU limits should be enforced Medium test
- mountPath: "/mnt/prompts/" | ||
name: model-volume | ||
containers: | ||
- name: download-model-prompts |
Check warning
Code scanning / SonarCloud
Memory limits should be enforced Medium test
name: ${model_name}-download-prompts | ||
labels: | ||
name: ${model_name}-download-prompts | ||
spec: |
Check warning
Code scanning / SonarCloud
Service account tokens should not be mounted in pods Medium test
- mountPath: "/mnt/prompts/" | ||
name: model-volume | ||
containers: | ||
- name: download-model-prompts |
Check warning
Code scanning / SonarCloud
Storage limits should be enforced Medium test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Robocop found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Robot Results
|
validation: |
|
fbc5b4c
into
red-hat-data-services:master
Besides adding the test for the model the PR introduces