Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sanity test for kueue #1249

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Add sanity test for kueue #1249

merged 1 commit into from
Mar 6, 2024

Conversation

ChughShilpa
Copy link
Contributor

github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 4, 2024
View reviewed changes
ods_ci/tests/Tests/650__distributed_workloads/test-run-kueue-e2e-tests.robot
... env:KUBECONFIG=${KUBECONFIG}
... env:NAMESPACE=${APPLICATIONS_NAMESPACE}
Log To Console ${result.stdout}
IF ${result.rc} != 0

Check notice

Code scanning / Robocop

IF can be replaced with inline IF Note test

IF can be replaced with inline IF
ods_ci/tests/Tests/650__distributed_workloads/test-run-kueue-e2e-tests.robot
... env:KUBECONFIG=${KUBECONFIG}
... env:NAMESPACE=${APPLICATIONS_NAMESPACE}
Log To Console ${result.stdout}
IF ${result.rc} != 0

Check notice

Code scanning / Robocop

'{{ block_name }}' condition can be simplified Note test

'IF' condition can be simplified
ods_ci/tests/Tests/650__distributed_workloads/test-run-kueue-e2e-tests.robot
[Tags] Sanity
... Kueue
... DistributedWorkloads
Run Kueue E2E Test e2e_test.go
Run Kueue sanity Test Should run with prebuilt workload

Check warning

Code scanning / Robocop

Keyword name '{{ keyword_name }}' does not follow case convention Warning test

Keyword name 'Run Kueue sanity Test' does not follow case convention
ods_ci/tests/Tests/650__distributed_workloads/test-run-kueue-e2e-tests.robot

Run Kueue sanity Test
[Documentation] Run Kueue Sanity Test
[Arguments] ${test_name}

Check warning

Code scanning / Robocop

{{ var_or_arg }} '{{ variable_name }}' overwrites reserved variable '{{ reserved_variable }}' Warning test

Argument '${test_name}' overwrites reserved variable '${TEST_NAME}'
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 4, 2024 •
edited
Loading

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
433 0 0 433 100

@ChughShilpa ChughShilpa force-pushed the add_sanity_test_for_kueue branch from e8cb925 to 4b0ab78 Compare March 4, 2024 14:14
sutaakar
sutaakar approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@sutaakar sutaakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ChughShilpa ChughShilpa force-pushed the add_sanity_test_for_kueue branch from 4b0ab78 to 8a5d02e Compare March 6, 2024 07:00
@ChughShilpa ChughShilpa force-pushed the add_sanity_test_for_kueue branch from 8a5d02e to 0023988 Compare March 6, 2024 11:00
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jiripetrlik jiripetrlik merged commit 0d18544 into red-hat-data-services:master Mar 6, 2024
12 checks passed
@ChughShilpa ChughShilpa deleted the add_sanity_test_for_kueue branch December 26, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sutaakar sutaakar sutaakar approved these changes

@jiripetrlik jiripetrlik jiripetrlik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChughShilpa @sutaakar @jiripetrlik