Improve utils.execute_command, add a Pytest selftest for it, and run it in GHA
#1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiridanek
commented
Mar 1, 2024
jiridanek
commented
Mar 1, 2024
| @@ -53,13 +53,12 @@ def read_yaml(filename): | |||
| return None | |||
|
|
|||
|
|
|||
| def execute_command(cmd): | |||
| def execute_command(cmd, print_stdout=True): | |||
There was a problem hiding this comment.
this is to have an option to quiet down the output in selftests
jiridanek
added
needs testing
Robot Results
|
|
Run this twice, there was only a test fail in "Verify that the must-gather image provides RHODS logs and info", which is known open issue, https://redhat-internal.slack.com/archives/C03V3J222D7/p1707985201274959?thread_ts=1707974794.266549&cid=C03V3J222D7 CI: job/rhods/job/rhods-ci-pr-test/2544/ |
jiridanek
added
verified
jstourac
reviewed
Mar 3, 2024
jstourac
reviewed
Mar 3, 2024
jstourac
previously approved these changes
Mar 3, 2024
…n it in GHA Fixes red-hat-data-services#1241 Signed-off-by: Jiri Daněk <jdanek@redhat.com>
Signed-off-by: Jiri Daněk <jdanek@redhat.com>
Co-authored-by: Jan Stourac <jstourac@redhat.com>
|
jstourac
approved these changes
Mar 3, 2024
FedeAlonso
reviewed
Mar 4, 2024
FedeAlonso
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pytest is configured according to https://docs.pytest.org/en/7.1.x/explanation/goodpractices.html#tests-as-part-of-application-code
I am using the same
poetrycommand for both the ruff and pytest jobs, so that they can share cache.Fixes #1241
CI: job/rhods/job/rhods-ci-pr-test/2543/ PASSED w/ known issues (see last comment for CI rerun)