Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding TC for model serving setting page #1076

Merged
merged 25 commits into from
Feb 29, 2024
Merged

adding TC for model serving setting page #1076

merged 25 commits into from
Feb 29, 2024

Conversation

mwaykole
Copy link
Member

No description provided.

@mwaykole
adding TC for model serving setting page
a09336c 
Signed-off-by: mwaykole <mwaykole@redhat.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 13, 2023
View reviewed changes
ods_ci/tests/Tests/400__ods_dashboard/420__model_serving/420__model_serving.robot Outdated
Delete Data Science Project ${PRJ_TITLE}
Wait Until Data Science Project Is Deleted ${PRJ_TITLE}
Click Both Model Serving Platforms

Check warning

Code scanning / Robocop

Invalid number of empty lines between sections ({{ empty_lines }}/{{ allowed_empty_lines }}) Warning test

Invalid number of empty lines between sections (1/2)
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 13, 2023 •
edited
Loading

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
429 0 0 429 100

lugi0
lugi0 reviewed Dec 13, 2023
View reviewed changes
Copy link
Contributor

@lugi0 lugi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this still needs some work

github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 26, 2024
View reviewed changes
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Robocop found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@mwaykole
adding TC for model serving setting page
9215888 
Signed-off-by: mwaykole <mwaykole@redhat.com>
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 28, 2024
View reviewed changes
...i/tests/Tests/400__ods_dashboard/420__model_serving/424__model_serving_cluster_setting.robot
Wait Until Page Contains Element //*[@id="multi-serving-platform-card"]

Verify Correct Value in DS Project after Enabling Multi Model Serving Platforms Only
[Documentation] Verifies that correct values are present in the DS project after enabling Multi Model serving platforms only

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (131/120)
...i/tests/Tests/400__ods_dashboard/420__model_serving/424__model_serving_cluster_setting.robot
Page Should Not Contain Element //button[contains(text(), 'Deploy model')]

Verify Correct Value in DS Project after Enabling Single Model Serving Platforms Only
[Documentation] Verifies that correct values are present in the DS project after enabling Single Model model serving platforms only

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (138/120)
@mwaykole
adding TC for model serving setting page
f2efe49 
Signed-off-by: mwaykole <mwaykole@redhat.com>
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 29, 2024
View reviewed changes
...i/tests/Tests/400__ods_dashboard/420__model_serving/424__model_serving_cluster_setting.robot
Wait Until Page Contains Element //*[contains(text(), "No model serving platform selected")]
Page Should Not Contain Element /button[contains(text(), 'Add model server')]
Page Should Not Contain Element //button[contains(text(), 'Deploy model')]

Check warning

Code scanning / Robocop

Invalid number of empty lines between sections ({{ empty_lines }}/{{ allowed_empty_lines }}) Warning test

Invalid number of empty lines between sections (1/2)
...i/tests/Tests/400__ods_dashboard/420__model_serving/424__model_serving_cluster_setting.robot
Open Data Science Projects Home Page
Create Data Science Project title=${project_title} description=test project

Model Serving Cluster Setting Test Setup

Check warning

Code scanning / Robocop

Keyword '{{ keyword_name }}' has too many keywords inside ({{ keyword_count }}/{{ max_allowed_count }}) Warning test

Keyword 'Model Serving Cluster Setting Test Setup' has too many keywords inside (11/10)
...i/tests/Tests/400__ods_dashboard/420__model_serving/424__model_serving_cluster_setting.robot
Comment on lines +83 to +84

Model Serving Cluster Setting Suite Teardown

Check warning

Code scanning / Robocop

Invalid number of empty lines between keywords ({{ empty_lines }}/{{ allowed_empty_lines }}) Warning test

Invalid number of empty lines between keywords (2/1)
@mwaykole
adding TC for model serving setting page
9019e91 
Signed-off-by: mwaykole <mwaykole@redhat.com>
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 29, 2024
View reviewed changes
...i/tests/Tests/400__ods_dashboard/420__model_serving/424__model_serving_cluster_setting.robot
*** Test Cases ***
Verify Correct Value in DS Project after Enabling Both Model Serving Platforms
[Documentation] Verifies that correct values are present in the DS project after enabling both model serving platforms
[Tags] ODS-2574

Check notice

Code scanning / Robocop

Tag '{{ tag }}' is already set by {{ test_force_tags }} in suite settings Note test

Tag 'ODS-2574' is already set by Test Tags in suite settings
...i/tests/Tests/400__ods_dashboard/420__model_serving/424__model_serving_cluster_setting.robot

Verify Correct Value in DS Project after Enabling Multi Model Serving Platforms Only
[Documentation] Verifies that correct values are present in the DS project after enabling Multi Model serving platforms only
[Tags] ODS-2574

Check notice

Code scanning / Robocop

Tag '{{ tag }}' is already set by {{ test_force_tags }} in suite settings Note test

Tag 'ODS-2574' is already set by Test Tags in suite settings
...i/tests/Tests/400__ods_dashboard/420__model_serving/424__model_serving_cluster_setting.robot

Verify Correct Value in DS Project after Enabling Single Model Serving Platforms Only
[Documentation] Verifies that correct values are present in the DS project after enabling Single Model model serving platforms only
[Tags] ODS-2574

Check notice

Code scanning / Robocop

Tag '{{ tag }}' is already set by {{ test_force_tags }} in suite settings Note test

Tag 'ODS-2574' is already set by Test Tags in suite settings
...i/tests/Tests/400__ods_dashboard/420__model_serving/424__model_serving_cluster_setting.robot

Verify Correct Value in DS Project after Disabling Both Model Serving Platforms
[Documentation] Verifies that correct values are present in the DS project after disabling both model serving platforms
[Tags] ODS-2574

Check notice

Code scanning / Robocop

Tag '{{ tag }}' is already set by {{ test_force_tags }} in suite settings Note test

Tag 'ODS-2574' is already set by Test Tags in suite settings
@bdattoma bdattoma added needs testing Needs to be tested in Jenkins new test New test(s) added (PR will be listed in release-notes) labels Feb 29, 2024
bdattoma
bdattoma previously approved these changes Feb 29, 2024
View reviewed changes
@bdattoma bdattoma requested a review from lugi0 February 29, 2024 09:15
@mwaykole
adding TC for model serving setting page
a2ace47 
Signed-off-by: mwaykole <mwaykole@redhat.com>
@mwaykole mwaykole removed the needs testing Needs to be tested in Jenkins label Feb 29, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mwaykole
Copy link
Member Author

image
Verified

@mwaykole mwaykole added the verified This PR has been tested with Jenkins label Feb 29, 2024
@mwaykole mwaykole requested a review from bdattoma February 29, 2024 10:27
@mwaykole mwaykole dismissed lugi0’s stale review February 29, 2024 10:44

changes done

@mwaykole mwaykole requested a review from aloganat February 29, 2024 12:23
@mwaykole mwaykole merged commit 99ba98b into red-hat-data-services:master Feb 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloganat aloganat aloganat approved these changes

@bdattoma bdattoma bdattoma approved these changes

@tarukumar tarukumar Awaiting requested review from tarukumar

@lugi0 lugi0 Awaiting requested review from lugi0

Assignees

@mwaykole mwaykole

Labels
new test New test(s) added (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mwaykole @aloganat @lugi0 @bdattoma