Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment failing tests due to configuration of AzureML #1907

Merged
merged 8 commits into from
Mar 29, 2023
+21 −11
Merged

Comment failing tests due to configuration of AzureML #1907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f904379
comment spark benchmark test issue #1898
miguelgfierro Mar 27, 2023
2349a3b
comment gpu test issue #1883
miguelgfierro Mar 27, 2023
b6f2042
comment gpu test issue #1883
miguelgfierro Mar 27, 2023
639e8e9
comment gpu test issue #1883
miguelgfierro Mar 27, 2023
9d0f781
ssh access and scale down if idle
miguelgfierro Mar 27, 2023
0eb27ea
comment gpu test issue #1883
miguelgfierro Mar 28, 2023
defc384
comment gpu test issue #1883
miguelgfierro Mar 28, 2023
2ad631c
reorder tests to reduce overall time
miguelgfierro Mar 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tests/ci/azureml_tests/submit_groupwise_azureml_pytest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,10 @@ def setup_persistent_compute_target(workspace, cluster_name, vm_size, max_nodes)
except ComputeTargetException:
logger.debug("setup: create cluster")
compute_config = AmlCompute.provisioning_configuration(
vm_size=vm_size, max_nodes=max_nodes
vm_size=vm_size,
max_nodes=max_nodes,
ssh_public_access_enabled=True,
idle_time_before_scale_down=3600, # 1 hour
)
cpu_cluster = ComputeTarget.create(workspace, cluster_name, compute_config)
cpu_cluster.wait_for_completion(show_output=False)
Expand Down
27 changes: 17 additions & 10 deletions tests/ci/azureml_tests/test_groups.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,8 @@
"group_gpu_002": [ # Total group time: 1896.76s
"tests/unit/examples/test_notebooks_gpu.py::test_gpu_vm", # 0.76s (Always the first test to check the GPU works)
"tests/smoke/recommenders/recommender/test_deeprec_model.py::test_model_xdeepfm", # 3.10s
"tests/smoke/examples/test_notebooks_gpu.py::test_xdeepfm_smoke", # 77.93s
# FIXME: https://github.com/microsoft/recommenders/issues/1883
# "tests/smoke/examples/test_notebooks_gpu.py::test_xdeepfm_smoke", # 77.93s
"tests/integration/examples/test_notebooks_gpu.py::test_xdeepfm_integration", # 470.11s
#
"tests/smoke/examples/test_notebooks_gpu.py::test_cornac_bivae_smoke", # 67.84s
Expand All @@ -97,38 +98,43 @@
"tests/integration/examples/test_notebooks_gpu.py::test_ncf_deep_dive_integration", # 351.17s
#
"tests/smoke/recommenders/recommender/test_newsrec_utils.py::test_naml_iterator", # 5.50s
"tests/smoke/recommenders/recommender/test_newsrec_model.py::test_model_naml", # 450.65s
# FIXME: https://github.com/microsoft/recommenders/issues/1883
# "tests/smoke/recommenders/recommender/test_newsrec_model.py::test_model_naml", # 450.65s
],
"group_gpu_004": [ # Total group time: 2103.34s
"tests/unit/examples/test_notebooks_gpu.py::test_gpu_vm", # 0.76s (Always the first test to check the GPU works)
"tests/smoke/examples/test_notebooks_gpu.py::test_nrms_smoke", # 232.55s
"tests/integration/examples/test_notebooks_gpu.py::test_nrms_quickstart_integration", # 857.05s
# FIXME: https://github.com/microsoft/recommenders/issues/1883
# "tests/integration/examples/test_notebooks_gpu.py::test_nrms_quickstart_integration", # 857.05s
#
"tests/smoke/examples/test_notebooks_gpu.py::test_lstur_smoke", # 246.46s
"tests/integration/examples/test_notebooks_gpu.py::test_lstur_quickstart_integration", # 766.52s
# FIXME: https://github.com/microsoft/recommenders/issues/1883
# "tests/integration/examples/test_notebooks_gpu.py::test_lstur_quickstart_integration", # 766.52s
],
"group_gpu_005": [ # Total group time: 1844.05s
"tests/unit/examples/test_notebooks_gpu.py::test_gpu_vm", # 0.76s (Always the first test to check the GPU works)
"tests/integration/examples/test_notebooks_gpu.py::test_wide_deep_integration", # 1843.29s
#
"tests/smoke/examples/test_notebooks_gpu.py::test_npa_smoke", # 366.22s
# FIXME: https://github.com/microsoft/recommenders/issues/1883
# "tests/integration/examples/test_notebooks_gpu.py::test_npa_quickstart_integration", # 810.92s
],
"group_gpu_006": [ # Total group time: 1763.99s
"tests/unit/examples/test_notebooks_gpu.py::test_gpu_vm", # 0.76s (Always the first test to check the GPU works)
"tests/smoke/recommenders/recommender/test_newsrec_model.py::test_model_npa", # 202.61s
"tests/smoke/recommenders/recommender/test_newsrec_model.py::test_model_nrms", # 188.60s
"tests/smoke/recommenders/recommender/test_newsrec_model.py::test_model_lstur", # 194.88s
#
"tests/smoke/examples/test_notebooks_gpu.py::test_npa_smoke", # 366.22s
"tests/integration/examples/test_notebooks_gpu.py::test_npa_quickstart_integration", # 810.92s
],
"group_gpu_007": [ # Total group time: 846.89s
"tests/unit/examples/test_notebooks_gpu.py::test_gpu_vm", # 0.76s (Always the first test to check the GPU works)
"tests/smoke/examples/test_notebooks_gpu.py::test_naml_smoke", # 620.13s
# FIXME: https://github.com/microsoft/recommenders/issues/1883
# "tests/smoke/examples/test_notebooks_gpu.py::test_naml_smoke", # 620.13s
#
"tests/integration/examples/test_notebooks_gpu.py::test_benchmark_movielens_gpu", # 226s
# FIXME: Reduce test time https://github.com/microsoft/recommenders/issues/1731
# "tests/integration/examples/test_notebooks_gpu.py::test_naml_quickstart_integration", # 2033.85s
# FIXME: https://github.com/microsoft/recommenders/issues/1716
# "tests/integration/examples/test_notebooks_gpu.py::test_sasrec_quickstart_integration", # 448.06s + 614.69s
"tests/smoke/recommenders/recommender/test_newsrec_model.py::test_model_lstur", # 194.88s
],
"group_spark_001": [ # Total group time: 987.16s
"tests/smoke/recommenders/dataset/test_movielens.py::test_load_spark_df", # 4.33s
Expand All @@ -140,7 +146,8 @@
#
"tests/smoke/examples/test_notebooks_pyspark.py::test_als_pyspark_smoke", # 49.53s
"tests/integration/examples/test_notebooks_pyspark.py::test_als_pyspark_integration", # 110.58s
"tests/integration/examples/test_notebooks_pyspark.py::test_benchmark_movielens_pyspark", # 142
# FIXME: https://github.com/microsoft/recommenders/issues/1898
# "tests/integration/examples/test_notebooks_pyspark.py::test_benchmark_movielens_pyspark", # 142s
],
}

Expand Down