Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade scikit-learn to latest version (1.0.2) #1653

Merged
merged 2 commits into from
Feb 28, 2022
Merged

Upgrade scikit-learn to latest version (1.0.2) #1653

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dea4af3
Upgrade scikit-learn
anargyri Feb 25, 2022
4719bc9
Merge branch 'staging' into andreas/scikit
anargyri Feb 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"scipy>=1.0.0,<2",
"tqdm>=4.31.1,<5",
"matplotlib>=2.2.2,<4",
"scikit-learn>=0.22.1,<1",
"scikit-learn>=0.22.1,<1.0.3",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any breaking change between <1 and >1?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, mainly Python < 3.7 isn't supported. But we still have scikit-learn>=0.22.1, so Python 3.6 is ok.
See https://pypi.org/project/scikit-learn/1.0/

Scikit-learn 0.20 was the last version to support Python 2.7 and Python 3.4. scikit-learn 0.23 and later require Python 3.6 or newer. scikit-learn 1.0 and later require Python 3.7 or newer.

"numba>=0.38.1,<1",
"lightfm>=1.15,<2",
"lightgbm>=2.2.1",
Expand Down