Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no_std build by removing unused dependency #433

Merged
merged 1 commit into from
Feb 18, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

- Remove unused `hex` dependencies which broke `no_std` ([#433])

[#433]: https://github.com/recmo/uint/pull/433

## [1.13.0] - 2025-02-18

- Support for borsh @ 1.5 ([#416])
Expand Down
1 change: 0 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ sqlx-core = { version = "0.8.2", optional = true }

# borsh
borsh = { version = "1.5", optional = true, default-features = false }
hex = "0.4"

[dev-dependencies]
ruint = { path = ".", features = ["arbitrary", "proptest"] }
Expand Down
4 changes: 0 additions & 4 deletions src/algorithms/gcd/matrix.rs
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,6 @@ impl Matrix {

// Compute a2
let q = a0 / a1;
// dbg!(q);
let mut a2 = a0 - q * a1;
let mut k2 = k0 + q * k1;
if a2 < LIMIT {
Expand All @@ -205,7 +204,6 @@ impl Matrix {

// Compute a3
let q = a1 / a2;
// dbg!(q);
let mut a3 = a1 - q * a2;
let mut k3 = k1 + q * k2;

Expand All @@ -222,7 +220,6 @@ impl Matrix {
debug_assert!(a2 < a3);
debug_assert!(a2 > 0);
let q = a3 / a2;
// dbg!(q);
a3 -= q * a2;
k3 += q * k2;
if a3 < LIMIT {
Expand All @@ -239,7 +236,6 @@ impl Matrix {
debug_assert!(a2 < a3);
debug_assert!(a2 > 0);
let q = a3 / a2;
// dbg!(q);
a3 -= q * a2;
k3 += q * k2;
}
Expand Down
1 change: 0 additions & 1 deletion src/bits.rs
Original file line number Diff line number Diff line change
Expand Up @@ -819,7 +819,6 @@ mod tests {
type U = Uint::<BITS, LIMBS>;
proptest!(|(value: U, shift in 0..=BITS + 2)| {
let shifted = value.arithmetic_shr(shift);
// dbg!(value, shifted, shift);
assert_eq!(shifted.leading_ones(), match value.leading_ones() {
0 => 0,
n => min(BITS, n + shift)
Expand Down
1 change: 1 addition & 0 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
clippy::cast_lossless,
)]
#![cfg_attr(test, allow(clippy::wildcard_imports, clippy::cognitive_complexity))]
#![cfg_attr(not(test), warn(unused_crate_dependencies))]
#![cfg_attr(not(feature = "std"), no_std)]
// Unstable features
#![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
Expand Down
3 changes: 0 additions & 3 deletions src/support/postgres.rs
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,6 @@ mod tests {
if ty == &Type::FLOAT8 && f64::from(value).is_infinite() {
return;
}
// dbg!(hex::encode(&serialized));

// Fetch ground truth value from Postgres
let expr = match *ty {
Expand All @@ -461,12 +460,10 @@ mod tests {
Type::JSON | Type::JSONB => format!("'\"{value:#x}\"'::{}", ty.name()),
_ => format!("{value}::{}", ty.name()),
};
// dbg!(&expr);
let ground_truth = {
let mut client = client.lock().unwrap();
get_binary(&mut client, &expr)
};
// dbg!(hex::encode(&ground_truth));

// Compare with ground truth, for float we allow tiny rounding error
if ty == &Type::FLOAT4 {
Expand Down
Loading