fix: swap bytes for as_le_bytes
in big endian world
#431
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Was tweaking https://github.com/op-rs/kona which has this repo as a dependency. Compiled kona down to mips64 which is big endian, and spotted this bug while comparing the results with little endian arch.
Minimal reproduction:
When we print
out
variable...[132, 18, 52, 86, 120]
, which is correct[132, 72, 44, 106, 30]
, which is wrong.both results must be identical.
Solution
Must swap bytes for big endian architectures, not reversing bits.
PR Checklist