Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ssz encode and decode for uint #344

Merged
merged 7 commits into from
Nov 15, 2023
Merged

Conversation

loocapro
Copy link
Contributor

@loocapro loocapro commented Nov 11, 2023

Motivation

Completing SSZ implementation also for Uint types: alloy-rs/core#407

Solution

Implementing Encode and Decode traits from https://github.com/sigp/ethereum_ssz

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

@loocapro loocapro marked this pull request as ready for review November 11, 2023 16:09
Copy link
Contributor

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs a separate explicit feature instead of the implicit one

Copy link

codecov bot commented Nov 12, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (7c0c88c) 80.57% compared to head (24d9f48) 80.53%.

Files Patch % Lines
src/support/ssz.rs 72.22% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #344      +/-   ##
==========================================
- Coverage   80.57%   80.53%   -0.05%     
==========================================
  Files          54       55       +1     
  Lines        6179     6231      +52     
==========================================
+ Hits         4979     5018      +39     
- Misses       1200     1213      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prestwich
Copy link
Collaborator

prestwich commented Nov 12, 2023

Looks like tiny-keccak is CC0-1.0 which is odd. We'll need to explicitly add that license to the approved list in deny.toml

@prestwich
Copy link
Collaborator

okay last thing I promise, please update CHANGELOG.md 🖖

@prestwich prestwich merged commit b837971 into recmo:main Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants