Pin Clap versions to support MSRV policy #306
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Latest version of criterion (0.5.1) use
clap@4
but latest version ofclap
set MSRV to1.70.0
so that CI for Rust1.65
continuously fails.Solution
Pin the versions of
clap
andclap_lex
to versions with MSRV set to1.65
. Should be safe as criterion is a dev-dependency.PR Checklist