Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Clap versions to support MSRV policy #306

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Pin Clap versions to support MSRV policy #306

merged 2 commits into from
Sep 6, 2023

Conversation

tonyke-bot
Copy link
Contributor

Motivation

Latest version of criterion (0.5.1) use clap@4 but latest version of clap set MSRV to 1.70.0 so that CI for Rust 1.65 continuously fails.

Solution

Pin the versions of clap and clap_lex to versions with MSRV set to 1.65. Should be safe as criterion is a dev-dependency.

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

@prestwich prestwich linked an issue Sep 6, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.13% 🎉

Comparison is base (585c5ce) 80.24% compared to head (b10a2b3) 80.37%.

❗ Current head b10a2b3 differs from pull request most recent head 0fb417c. Consider uploading reports for the commit 0fb417c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #306      +/-   ##
==========================================
+ Coverage   80.24%   80.37%   +0.13%     
==========================================
  Files          54       54              
  Lines        5994     5983      -11     
==========================================
- Hits         4810     4809       -1     
+ Misses       1184     1174      -10     

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@prestwich prestwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prestwich prestwich enabled auto-merge September 6, 2023 17:29
@prestwich prestwich self-assigned this Sep 6, 2023
@prestwich prestwich added bug Something isn't working dependencies Pull requests that update a dependency file labels Sep 6, 2023
@prestwich prestwich merged commit 76f9aa7 into recmo:main Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chore: pin Clap versions to support MSRV policy
2 participants