-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: minimal human-readable serialization of uints #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chore: changelog fix: result(s) lint: clippy::uninlined_format_args fix: undo reformatting changelog
mattsse
approved these changes
May 12, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #243 +/- ##
=======================================
Coverage ? 84.96%
=======================================
Files ? 50
Lines ? 5986
Branches ? 0
=======================================
Hits ? 5086
Misses ? 900
Partials ? 0
☔ View full report in Codecov by Sentry. |
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #225
Closes #224
Motivation
Quantity
spec for uint serialization0x0
for the value0
Solution
serialize_human_full
serialize_human_minimal
andserialize_binary
serialize_binary
for non-human-readable serializersserialize_human_full
for bits in a human-readable serializerserialize_human_minimal
for uints in a human-readable serializerThis work is based on #225, but moves the functionality into differentiated methods, rather than a single method, and biases towards iterator usage
This PR is semver minor as the serialization output will change in a backwards-compatible way
PR Checklist