Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated example project to MAUI and Source Generators #3168

Merged
merged 10 commits into from
Jan 16, 2023

Conversation

papafe
Copy link
Contributor

@papafe papafe commented Jan 9, 2023

Updated example project to use MAUI and the new source generator models.
I've also slightly modified the way the example work. Before the user had to explicitly press "Save" to save his entry, and we had an open transaction to implement this. This is a pattern we don't recommend, so I've modified this, and all the changes are directly saved in the db. If when returning to the main screen the note that was being modified is empty, then it's removed and a toast appears (as it happens with Google Notes).
This is implemented using the MessagingCenter. The initial implementation was specifying Shell.BackButtonBehaviour, but this was causing a crash due to a bug in MAUI (dotnet/maui#11438).

Fixes also #3032

@cla-bot cla-bot bot added the cla: yes label Jan 9, 2023
@papafe papafe added the no-changelog Used to skip the changelog check label Jan 9, 2023
@papafe papafe requested review from nirinchev and LaPeste January 9, 2023 15:34
papafe added 2 commits January 9, 2023 16:40
* main:
  🔄 Synced file(s) with realm/ci-actions (#3160)
  Prepare for vNext (#3159)
  Prepare for 10.19.0 (#3158)
  Deprecate legacy error codes (#3156)
  Bump json5 from 1.0.1 to 1.0.2 in /.github/actions/benchmark-uploader (#3153)
  Fix string.Contains with .NET 2.1 or higher (#3154)
  Bring back IList conformance to RealmCollectionBase (#3150)
  Use the tagged version
  Add no-response workflow to close stale issues (#3152)
  Fix Realm not getting reinitialized when domain reload is disabled (#3145)
  Revert to using Core 12 (#3146)
  Fix generated usings (#3148)
  Update bug.yml (#3142)
Copy link
Member

@nirinchev nirinchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, minor comments and suggestions from me.

@papafe papafe merged commit c053966 into main Jan 16, 2023
@papafe papafe deleted the fp/update-quickjournal branch January 16, 2023 11:43
papafe added a commit that referenced this pull request Jan 27, 2023
* main:
  Survey ad (#3201)
  Workaround Mono yield bug (#3200)
  Bump docker layer caching action to use node16 (#3193)
  Keypath filtering (#3179)
  Move realm files created by tests to current directory on CI (#2991)
  Fix failing sync tests (#3096)
  Updated example project to MAUI and Source Generators (#3168)
  Fix uwp workflow when running in debug (#3177)
  Deprecate push client (#3176)
  Don't use reflection in DynamicRealmObjectHelper.TryGetPrimaryKeyValue (#3175)
  Keep track of the active transaction and close it on realm close (#3164)
  Add more detailed unsupported type error (#3163)
  Build Xamarin.Android tests in all ABIs (#3165)

# Conflicts:
#	Tests/Realm.Tests/Generated/Realm.SourceGenerator/Realms.SourceGenerator.RealmGenerator/ObjectWithPartitionValue_generated.cs
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes no-changelog Used to skip the changelog check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants