Updated test projects to .netcore 3.1 #2234
Conversation
CHANGELOG.md
Outdated
| @@ -29,6 +29,7 @@ | |||
|
|
|||
| ### Internal | |||
| * Using Core 10.3.3. | |||
| * Updated to dotnetcore 3.1. | |||
There was a problem hiding this comment.
This should say that only test projects were updated and also make a note that we're no longer testing .NET Core 2.0.
global.json
Outdated
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "msbuild-sdks": { | |||
| "MSBuild.Sdk.Extras": "2.1.2" | |||
| "MSBuild.Sdk.Extras": "3.0.23" | |||
There was a problem hiding this comment.
I don't mind the change, just curious - why was it necessary? Since we previously targeted .NET 5, it's a bit surprising that the package didn't support 3.1.
There was a problem hiding this comment.
There is a problem with importing Microsoft.WinFX.props on Linux. Reading here there seem to be problems with MSBuildExtras in linux since April 2020 exactly with this Microsoft.WinFX.props. Even when the patch was in the sdk it didn't seem to work unless you "patch yourself" some settings. Before doing anything I just gave a shot to the latest version of MSBuild.Sdk.Extras just to see if that would have helped. Which it didn't, so I'll revert.
There was a problem hiding this comment.
I see. I guess we can use the workaround from that post then.
There was a problem hiding this comment.
Looks like the renaming workaround should be special-cased for the 3.1 image and you may need to create a custom image that derives from the MS one to solve the permissions issue. Might want to try and ping @fealebenpae as the resident docker guru.
* Remove nodefaultlib workaround that was used for server wrappers * capitalize NOT * Recreate UWP and get tests runnable again * cleanup rd.xml * Changelog entry
…y) (#2243) * Merge relevant portions from v10 and bump version to 10.5 (arbitrarily) * Have the changelog use 10.5.0 temporarily
* Enable LTO + backport iOS build fix * Replace -Oz with -O2 if LTO is enabled * Disable interprocedural_optimization for android * Enable LTO for UWP builds * Add changelog entry * Disable LTO for PR builds
This reverts commit afd0c3f.
Description
.netcore 2.0 is approaching EOL. This PR bumps up the version of .netcore to 3.1 wherever it's used.
Fixes #2117
TODO