Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore coverage in generated files #1827

Closed
wants to merge 3 commits into from

Conversation

NatsuOnFire
Copy link

PR to resolve issue #1826

Copy link

cla-bot bot commented Feb 10, 2025

Realm welcomes all contributions! The only requirement we have is that, like many other projects, we need to have a Contributor License Agreement (CLA) in place before we can accept any external code. Our own CLA is a modified version of the Apache Software Foundation’s CLA. Our records show that CLA has not been signed by @NatsuOnFire. Please submit your CLA electronically using our Google form so we can accept your submissions. After signing the CLA you can recheck this PR with a @cla-bot check comment. The GitHub usernames you file there will need to match that of your Pull Requests. If you have any questions or cannot file the CLA electronically, make a comment here and we will be happy to help you out.

@NatsuOnFire
Copy link
Author

@cla-bot check

1 similar comment
@NatsuOnFire
Copy link
Author

@cla-bot check

@cla-bot cla-bot bot added the cla: yes label Feb 10, 2025
Copy link

cla-bot bot commented Feb 10, 2025

The cla-bot has been summoned, and re-checked this pull request!

@nirinchev nirinchev changed the base branch from main to community February 10, 2025 18:21
@nirinchev nirinchev changed the base branch from community to main February 10, 2025 18:21
@nirinchev
Copy link
Member

Hey, thanks for this PR! I cherry-picked your commits (PR: #1828) over to the community branch, which is what we're using for non-sync changes. Tests seem to be all green and I'm going to go ahead and merge them.

@nirinchev nirinchev closed this Feb 11, 2025
@NatsuOnFire NatsuOnFire deleted the ignore-coverage-files branch February 11, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants