Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Error with sphinx-notfound-page 1.0.3 - 'tuple' object has no at… #241

Merged
merged 1 commit into from
Jul 31, 2024
Merged

fix: Error with sphinx-notfound-page 1.0.3 - 'tuple' object has no at… #241

merged 1 commit into from
Jul 31, 2024

Conversation

dgarcia360
Copy link
Contributor

@dgarcia360 dgarcia360 commented Jul 30, 2024 •
edited
Loading

Closes #240

How to test

Building a Sphinx 7.2.X project with this extension in a virtualenv should not return the 'tuple' object has no attribute 'default' error:

# 1. Install Sphinx 7.2.6
pip install sphinx==7.2.6

# 2. Install the extension
git clone https://github.com/readthedocs/sphinx-notfound-page.git
cd sphinx-notfound-page
gh pr checkout 241
pip install .

# 3. Create a new Sphinx project
cd ..
sphinx-quickstart test_project

# 4. Add the extension to conf.py
See https://github.com/readthedocs/sphinx-notfound-page?tab=readme-ov-file#configuration

# 5. Build the Sphinx project
cd test_project
make html

@dgarcia360 dgarcia360 marked this pull request as ready for review July 30, 2024 17:34
@dgarcia360 dgarcia360 requested a review from a team as a code owner July 30, 2024 17:34
@dgarcia360 dgarcia360 requested a review from stsewd July 30, 2024 17:34
This was referenced Jul 30, 2024
Closed
Merged
@ericholscher ericholscher requested a review from humitos July 30, 2024 18:46
@deepyaman deepyaman mentioned this pull request Jul 30, 2024
Merged
7 tasks
humitos added a commit that referenced this pull request Jul 31, 2024
@humitos
Tests: update test suite and fix some tests
40799b4 
I expect some versions to fail due to #240. If that's the case, we can merge #241
here and move forward with it.
@humitos humitos mentioned this pull request Jul 31, 2024
Merged
humitos added a commit that referenced this pull request Jul 31, 2024
@humitos
Tests: update test suite and fix some tests (#242)
fe10592 
* Update Git ignore

* Tests: update test suite and fix some tests

I expect some versions to fail due to #240. If that's the case, we can merge #241
here and move forward with it.
humitos
humitos approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. I updated the test suite in #242, so everything should be fine now 👍🏼

@humitos humitos merged commit 4a7a4db into readthedocs:main Jul 31, 2024
4 of 8 checks passed
@dgarcia360 dgarcia360 mentioned this pull request Jul 31, 2024
Closed
@humitos humitos mentioned this pull request Oct 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos approved these changes

@stsewd stsewd Awaiting requested review from stsewd stsewd is a code owner automatically assigned from readthedocs/backend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error with sphinx-notfound-page 1.0.3 - 'tuple' object has no attribute 'default'
2 participants
@dgarcia360 @humitos