refactor(open/openapi/validate): return promises, fix tests

[kanadgupta]

🧰 Changes

This rabbit hole of work is a continuation of the work started in #407 where I'm combing through and making sure we're returning resolved/rejected promises wherever possible and updating/standardizing our test suite patterns to ensure better coverage and to make debugging easier. In an effort to keep this PR easy to review (since most of the diff is just testbed refactors), I'm going to only include a few command refactors here:

1. open
   • Command updates
     • Refactored the main function so we're always returning a resolved/rejected promise
   • Testbed updates
     • Removed all console.log mocks
     • Refactored tests to use standard patterns and check for promise return value
2. openapi
   • Command updates
     • Refactored the main function so we're always returning a resolved/rejected promise
   • Testbed updates
     • Removed all console.log mocks
       • I wasn't able to fully remove the console mocks since I figured we'd still want to check for certain console outputs, but I refactored them to be console.info and console.warn calls so we can safely use console.log for our own debugging.
     • Refactored tests to use standard patterns and check for promise return value
       • In the process of doing this, I discovered several gaping holes in our test coverage due to nock value typos! The tests feel much more airtight now 🎉
3. validate
   • Command updates
     • Refactored the main function so we're always returning a resolved/rejected promise
   • Testbed updates
     • Removed all console.log mocks
       • Similar to the openapi command above, we're now using console.info instead.
     • Refactored tests to use standard patterns and check for promise return value

In separate PRs, I'll be doing the following:

• Adjusting our ESLint config to allow for console.info and console.warn calls in our main codebase, but nothing else. That way we can safely use console.log when debugging and not worry about a test mock eating it up.
  • (Also small related refactors of bin/rdme)
• Fixing several bugs in our docs commands that I discovered when performing similar refactors there
  • EDIT: see fix(docs): directory sync fix + test bed rewrites #421
• Fixing the bug associated with this TODO
  • EDIT: see fix(openapi): error handling for incorrect project and version flags #411

🧬 QA & Testing

Note that this PR doesn't actually fix any bugs in the main codebase itself, just standardizes our patterns and fixes a few test suite issues. If tests pass and you can run the above commands as expected, then we should be good to go.

[erunion]

super minor comments but these are all great refactors