Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add externals for node build #895

Merged
merged 1 commit into from
May 30, 2024
Merged

Conversation

Dashron
Copy link
Contributor

@Dashron Dashron commented May 30, 2024

PR App Fix RM-XYZ

🧰 Changes

This allows the renderer to inject its own util module, which react-dom/server relies on for access to TextEncoder.

🧬 QA & Testing

@Dashron Dashron changed the title Fix/externals for node build fix: add externals for node build May 30, 2024
@kellyjosephprice kellyjosephprice changed the base branch from next to beta May 30, 2024 19:38
@Dashron Dashron merged commit 3d6eb5d into beta May 30, 2024
9 of 11 checks passed
@Dashron Dashron deleted the fix/externalsForNodeBuild branch May 30, 2024 19:43
rafegoldberg pushed a commit that referenced this pull request May 30, 2024
## Version 6.75.0-beta.46

### 🛠 Fixes & Updates

* add externals for node build ([#895](#895)) ([3d6eb5d](3d6eb5d))

<!--SKIP CI-->
@rafegoldberg
Copy link
Contributor

This PR was released!

🚀 Changes included in v6.75.0-beta.46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants