feat: pass in react #859
Merged
feat: pass in react #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellyjosephprice
requested review from
jennspencer
and removed request for
erunion
Dashron
approved these changes
Apr 12, 2024
|
Sadly the more conventional way of just letting import work, requires the rest of our stack to be using import for react so we get the same one :( more hacks around legacy code. I do think this is something they should be supporting out of the box though. It doesn't need to be this opinionated. |
|
This PR was released!🚀 Changes included in v6.75.0-beta.25 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Allows importing
Reactwithin mdx.Aaron pointed out that we couldn't use react features such as
useState. The more conventional way to import react would be from a url, but this seemed simpler.🧬 QA & Testing