This repository has been archived by the owner on Jul 29, 2022. It is now read-only.
Fix broken server if a publication file contains special characters #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 21, 2020
Merged
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix readium/kotlin-toolkit#243
The web server was broken if the publication filename contained special characters, e.g.
9+Chemins+Nocturnes+%28Viviane+Hamy%29 copy.epub. This is fixed by percent-encoding the filename.We should use the
selflink inPublicationfor the base URL, but unfortunately this doesn't work right now without breaking reading apps, because thePublicationis serialized before adding theselflink when serving it in theServer. For now, I addedPublication::localBaseUrlOf()andPublication::localUrlOf()to centralize the sanitization code in a single place, until we fix theselflink issue.