Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump macOS minimum version to v11 #11

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

marcprux
Copy link

This enables ZIPFoundation (and thus the Readium swift-toolkit) to be built from the macOS CLI with swift build. Otherwise, the following errors occur:

zap appfair/ZIPFoundation % swift build
Building for debugging...
/opt/src/github/appfair/ZIPFoundation/Sources/ZIPFoundation/FileManager+ZIP.swift:104:48: error: 'reduce' is only available in macOS 10.15 or newer
 11 | import Foundation
 12 | 
 13 | extension FileManager {
    | `- note: add @available attribute to enclosing extension
 14 | 
 15 |     typealias CentralDirectoryStructure = Entry.CentralDirectoryStructure
    :
 92 |     ///   - pathEncoding: Encoding for entry paths. Overrides the encoding specified in the archive.
 93 |     /// - Throws: Throws an error if the source item does not exist or the destination URL is not writable.
 94 |     public func unzipItem(at sourceURL: URL, to destinationURL: URL,
    |                 `- note: add @available attribute to enclosing instance method
 95 |                           skipCRC32: Bool = false, allowUncontainedSymlinks: Bool = false,
 96 |                           progress: Progress? = nil, pathEncoding: String.Encoding? = nil) async throws {

Copy link
Member

@mickael-menu mickael-menu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Marc, thank you for your contribution!

Would you mind disabling the workflows, or fix the Xcode ones that don't seem to run properly? We don't need to support Linux at all for this fork. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants