Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc(cn): translate tutorial to zh-cn #12

Merged
merged 17 commits into from
Feb 25, 2019
Merged

doc(cn): translate tutorial to zh-cn #12

merged 17 commits into from
Feb 25, 2019

Conversation

yuqingc
Copy link
Member

@yuqingc yuqingc commented Feb 1, 2019 •
edited
Loading

Thank you for the PR! Contributors like you keep React awesome!

Please see the Contribution Guide for guidelines:

https://github.com/reactjs/reactjs.org/blob/master/CONTRIBUTING.md

If your PR references an existing issue, please add the issue number below

-->

@yuqingc yuqingc changed the title WIP:doc(cn): translate tutorial to zh-cn, first commit WIP:doc(cn): translate tutorial to zh-cn Feb 3, 2019
@yuqingc yuqingc changed the title WIP:doc(cn): translate tutorial to zh-cn doc(cn): translate tutorial to zh-cn Feb 3, 2019
@yuqingc yuqingc force-pushed the tutorial-cn branch 2 times, most recently from ac32d36 to e8c410a Compare February 3, 2019 07:11
QC-L
QC-L requested changes Feb 9, 2019
View reviewed changes
hijiangtao
hijiangtao requested changes Feb 10, 2019
View reviewed changes
Copy link
Member

@hijiangtao hijiangtao left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tutorial.md L1-L117 review

  1. 中英文空格问题需要通篇检查一下，中文之间不需要添加空格
  2. 部分单词如 class 前后文翻译需要保持一致
  3. 其他一些地方，表述稍有繁琐，可以修改

@QC-L QC-L added the Pending Review 已翻译，待校对阶段 label Feb 12, 2019
hijiangtao
hijiangtao requested changes Feb 13, 2019
View reviewed changes
Copy link
Member

@hijiangtao hijiangtao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

校对范围 L117-L225

@QC-L QC-L added Pending Modify 已校对，待修改阶段 and removed Pending Review 已翻译，待校对阶段 labels Feb 13, 2019
@tesseralis tesseralis mentioned this pull request Feb 14, 2019
Closed
@QC-L QC-L added Pending Re-Review 已修改，待审校阶段 and removed Pending Modify 已校对，待修改阶段 labels Feb 15, 2019
@hijiangtao hijiangtao mentioned this pull request Feb 15, 2019
Closed
QC-L
QC-L reviewed Feb 23, 2019
View reviewed changes
QC-L
QC-L reviewed Feb 23, 2019
View reviewed changes
QC-L
QC-L reviewed Feb 23, 2019
View reviewed changes
QC-L
QC-L reviewed Feb 23, 2019
View reviewed changes
QC-L
QC-L reviewed Feb 23, 2019
View reviewed changes
QC-L
QC-L reviewed Feb 23, 2019
View reviewed changes
QC-L
QC-L reviewed Feb 23, 2019
View reviewed changes
QC-L
QC-L reviewed Feb 23, 2019
View reviewed changes
QC-L
QC-L reviewed Feb 23, 2019
View reviewed changes
QC-L
QC-L reviewed Feb 23, 2019
View reviewed changes
QC-L
QC-L reviewed Feb 23, 2019
View reviewed changes
QC-L
QC-L reviewed Feb 23, 2019
View reviewed changes
QC-L
QC-L reviewed Feb 23, 2019
View reviewed changes
QC-L
QC-L reviewed Feb 23, 2019
View reviewed changes
QC-L
QC-L reviewed Feb 23, 2019
View reviewed changes
QC-L
QC-L reviewed Feb 23, 2019
View reviewed changes
content/tutorial/tutorial.md

We will also replace reading `this.state.history` with `this.state.history.slice(0, this.state.stepNumber + 1)`. This ensures that if we "go back in time" and then make a new move from that point, we throw away all the "future" history that would now become incorrect.
我们还把读取 `this.state.history` 换成了读取 `this.state.history.slice(0, this.state.stepNumber + 1)` 的值。如果我们“回到过去”，然后再走一步新棋子，原来的“未来”历史记录就不正确了，这个替换可以保证我们把这些“未来”的不正确的历史记录丢弃掉。
Copy link
Member

@QC-L QC-L Feb 23, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
我们还把读取 `this.state.history` 换成了读取 `this.state.history.slice(0, this.state.stepNumber + 1)` 的值。如果我们“回到过去”，然后再走一步新棋子，原来的“未来”历史记录就不正确了，这个替换可以保证我们把这些“未来”的不正确的历史记录丢弃掉。
还需要将 `this.state.history` 替换为 `this.state.history.slice(0, this.state.stepNumber + 1)`。如果我们“悔棋”，然后再走一步新棋子，原来的“未来”历史记录就不正确了，这个替换可以将这些不正确的“未来”历史记录丢弃掉。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending

QC-L
QC-L reviewed Feb 23, 2019
View reviewed changes
content/tutorial/tutorial.md Outdated
@@ -1188,41 +1188,41 @@ We will also replace reading `this.state.history` with `this.state.history.slice
}
```

Finally, we will modify the Game component's `render` method from always rendering the last move to rendering the currently selected move according to `stepNumber`:
最后一步，我们把 Game 组件的 `render` 方法从总是渲染最后一个步骤更改为，根据 stepNumber` 渲染当前选择的步骤。
Copy link
Member

@QC-L QC-L Feb 23, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
最后一步，我们把 Game 组件的 `render` 方法从总是渲染最后一个步骤更改为，根据 stepNumber` 渲染当前选择的步骤。
最后，修改 Game 组件的 `render` 方法，将代码从始终根据最后一次移动渲染修改为根据当前 `stepNumber` 渲染。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个貌似不太通顺

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

落子

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不是始终根据最后一次移动啊，from... to... 反了。。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuqingc 这句我修改了，你看下

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的 已改

QC-L
QC-L reviewed Feb 23, 2019
View reviewed changes
QC-L
QC-L reviewed Feb 23, 2019
View reviewed changes
QC-L
QC-L reviewed Feb 23, 2019
View reviewed changes
QC-L
QC-L reviewed Feb 23, 2019
View reviewed changes
@hijiangtao hijiangtao merged commit 3ffd3f3 into reactjs:cn Feb 25, 2019
QC-L pushed a commit that referenced this pull request Feb 25, 2019
@QC-L
docs(cn): translate tutorial to zh-cn (#12)
f4a7efc
OhIAmFine pushed a commit to OhIAmFine/zh-hans.reactjs.org that referenced this pull request May 6, 2019
@QC-L
docs(cn): translate tutorial to zh-cn (reactjs#12)
2a85ffd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hijiangtao hijiangtao hijiangtao approved these changes

@QC-L QC-L QC-L approved these changes

@dear-lizhihua dear-lizhihua Awaiting requested review from dear-lizhihua

@lcxfs1991 lcxfs1991 Awaiting requested review from lcxfs1991

@discountry discountry Awaiting requested review from discountry

Assignees
No one assigned
Labels
Pending Re-Review 已修改，待审校阶段
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuqingc @QC-L @hijiangtao