docs(cn): translate content/warnings/unknown-prop.md into Chinese #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for cn-reactjs ready! Built with commit 713848f |
Closed
LeoEatle
reviewed
Feb 18, 2019
LeoEatle
reviewed
Feb 18, 2019
content/warnings/unknown-prop.md
Outdated
|
|
||
| --- | ||
|
|
||
| To fix this, composite components should "consume" any prop that is intended for the composite component and not intended for the child component. Example: | ||
| 要解决这个问题，组合组件应该“消耗”任何用于复合组件的 prop，而不要用于子组件。例如： |
There was a problem hiding this comment.
Suggested change
| 要解决这个问题，组合组件应该“消耗”任何用于复合组件的 prop，而不要用于子组件。例如： | |
| 要解决这个问题，组合组件应该“处理”任何只用于复合组件的 prop，而不要用于子组件。例如： |
感觉用“处理”会比“消耗”更好理解，或许用“剥离”也可以，待讨论
加个“只”更有助于理解为什么不能让多余的props传入子组件。
LeoEatle
reviewed
Feb 18, 2019
LeoEatle
reviewed
Feb 18, 2019
LeoEatle
reviewed
Feb 18, 2019
LeoEatle
reviewed
Feb 18, 2019
LeoEatle
requested changes
Feb 18, 2019
hijiangtao
requested changes
Feb 18, 2019
There was a problem hiding this comment.
- 文中关于 Good / Bad 需要确认下是否为通用译法 @QC-L
- 译文需检查一遍，保持与原文行数一致
- 部分建议见 comments
感谢参与翻译工作！
QC-L
reviewed
Feb 19, 2019
QC-L
reviewed
Feb 19, 2019
QC-L
reviewed
Feb 19, 2019
LeoEatle
approved these changes
Feb 21, 2019
hijiangtao
added
Pending Re-Review
hijiangtao
approved these changes
Feb 24, 2019
QC-L
approved these changes
Feb 24, 2019
zhaozhiming
pushed a commit
to zhaozhiming/zh-hans.reactjs.org
that referenced
this pull request
Feb 25, 2019
OhIAmFine
pushed a commit
to OhIAmFine/zh-hans.reactjs.org
that referenced
this pull request
May 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://stackblitz.com/edit/react-unknown-prop
无法重现这个 warning 可能是我例子写得不够高级…