Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cn): translate content/docs/code-splitting.md into Chinese #11

Merged
merged 10 commits into from
Feb 18, 2019

Conversation

BetaMee
Copy link
Contributor

@BetaMee BetaMee commented Feb 1, 2019

No description provided.

@BetaMee BetaMee changed the title finish code splitting docs(cn): translate content/docs/code-splitting.md into Chinese Feb 1, 2019
@hijiangtao hijiangtao requested a review from QC-L February 1, 2019 10:38
@hijiangtao hijiangtao requested review from discountry and removed request for hijiangtao February 1, 2019 10:38
@QC-L QC-L requested a review from hijiangtao February 1, 2019 10:38
Copy link
Member

@yuqingc yuqingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should refactor your docs where there should be spaces around English words.

Copy link
Collaborator

@sang4lv sang4lv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一个小的建议,其他的改动 LGTM

@cyan33
Copy link
Collaborator

cyan33 commented Feb 12, 2019

Left a few nitpicks. Looks good overall. 👍

@QC-L QC-L added the Pending Re-Review 已修改,待审校阶段 label Feb 12, 2019
@QC-L QC-L added Pending Modify 已校对,待修改阶段 and removed Pending Re-Review 已修改,待审校阶段 labels Feb 13, 2019
@QC-L QC-L mentioned this pull request Feb 14, 2019
@QC-L QC-L added the Pending Re-Review 已修改,待审校阶段 label Feb 15, 2019
@QC-L QC-L removed the Pending Modify 已校对,待修改阶段 label Feb 15, 2019
>
> `React.lazy` and Suspense is not yet available for server-side rendering. If you want to do code-splitting in a server rendered app, we recommend [Loadable Components](https://github.com/smooth-code/loadable-components). It has a nice [guide for bundle splitting with server-side rendering](https://github.com/smooth-code/loadable-components/blob/master/packages/server/README.md).
> `React.lazy` 和 Suspense 技术还不支持服务端渲染。如果你想要在使用服务端渲染的应用中使用,我们推荐 [Loadable Components](https://github.com/smooth-code/loadable-components) 这个库。
> 它有一个很棒的[服务端渲染打包指南](https://github.com/smooth-code/loadable-components/blob/master/packages/server/README.md)。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里与上面是一行,你这多了一行

@QC-L QC-L merged commit e962260 into reactjs:cn Feb 18, 2019
@BetaMee BetaMee deleted the code-splitting branch February 18, 2019 03:14
OhIAmFine pushed a commit to OhIAmFine/zh-hans.reactjs.org that referenced this pull request May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pending Re-Review 已修改,待审校阶段
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants