-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Search functionality not working correctly on react.dev in Safari on iOS real device (iPhone 12 Pro) #6693
Comments
Hi @pwbriggs👋 |
Go ahead, @MeetYourCreator! Thanks in advance for the help! |
Hi @pwbriggs 👋
|
Yes, that's correct. Commit the changes to the branch on your fork, then open your fork on GitHub. You should see a message something like this: Hit the "Contribute" button to start a pull request. Include "Fixes #6693" in the description so GitHub will automatically link it to this issue. Thanks again! ❤️ |
* change isOpen variable in TopNav component to isMenuOpen to differentiate from isOpen props in Search component change setIsOpen to setIsMenuOpen in TopNav component * move initialization of ShowSearch state to top-level of TopNav component organize hook initializations in TopNav component: useState, useRef, useRouter * remove initialYScroll prop from DocSearchModal component to fix search functionality on ios devices
Summary
The current behavior
Search functionality does not work correctly on iOS real device (iPhone 12 Pro).
react_github-bug-report_current-behavior-1.mov
Since search functionality is currently working as expected on macOS, both in Chrome and Safari, the issue might be in implementation of Algolia InstantSearch iOS:
react_github-bug-report_current-behavior-2.mov
The expected behavior
Search functionality is working as expected on macOS, both in Chrome and Safari. Should work similarly on iOS real device:
macOs Chrome
search-functionality_chrome-macOS-v14.3.1.mp4
macOS Safari
search-functionality_safari-macOS-v14.3.1.mp4
Page
https://react.dev
Details
Steps To Reproduce
The iOS real device that this behavior was recorded on is using the current iOS version:
The text was updated successfully, but these errors were encountered: