This repository has been archived by the owner on Sep 21, 2022. It is now read-only.
Ability to mark subtree in render() for pre-rendering #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! @chrislloyd and myself here from Pinterest. We're currently looking at ways of doing grid layout in React and have a need to pre-render elements to calculate positioning data. We're contemplating using an approach similar to this pull request, and were soliciting feedback on how something like this would look in the core.
I'm worried about performance issues with the current implementation of preRender(), defined inside "02 - Layout Components". The main problem I currently see is that the component itself may have to do additional work to format children before they are measured. As another method you might need to split out your JSX from render(), and have that return an array of formatted objects. Being able to mark a section of the subtree to pre-render, as in this approach, feels cleaner.
Thanks!