Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Indonesian translation: importing and exporting components #345

Merged
merged 9 commits into from
Apr 28, 2023
Merged

New Indonesian translation: importing and exporting components #345

merged 9 commits into from
Apr 28, 2023

Conversation

aroyan
Copy link
Contributor

@aroyan aroyan commented Apr 26, 2023 •
edited by zainfathoni
Loading

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

r17x
r17x previously requested changes Apr 26, 2023
View reviewed changes
@aroyan @r17x
use italic for usage of file
9279bd8 
Co-authored-by: RiN <hi@rin.rocks>
@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@aroyan
Copy link
Contributor Author

aroyan commented Apr 26, 2023

Thanks for the suggestion @r17x. I have a question, what about usage of import/eksport? Should I use it with t or not? I've seen some translation is using impor/ekspor but the glossary is using it with t, so I'm not so sure which one to use

@aroyan @mazipan
Apply suggestions from code review
e05eff0 
- Use `impor/ekspor` instead of `import/eksport`
- Use `Ilmuwan` the standard one instead of `Ilmuan`
- Fix grammatical error

Co-authored-by: Irfan Maulana <mazipanneh@gmail.com>
@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

mhaidarhanif
mhaidarhanif requested changes Apr 27, 2023
View reviewed changes
Copy link
Collaborator

@mhaidarhanif mhaidarhanif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor suggestion.

@aroyan @mhaidarhanif
Update src/content/learn/importing-and-exporting-components.md
f9c01c1 
Co-authored-by: M Haidar Hanif <git@mhaidarhanif.com>
@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@mhaidarhanif
Copy link
Collaborator

@aroyan I have a question, what about usage of import/eksport? Should I use it with t or not? I've seen some translation is using impor/ekspor but the glossary is using it with t, so I'm not so sure which one to use

About this one (not sure if already clarified or not in this PR), we can check and discuss it here: #337 (comment)

The official pair from KBBI are impor and ekspor.

@aroyan
Copy link
Contributor Author

aroyan commented Apr 28, 2023

@aroyan I have a question, what about usage of import/eksport? Should I use it with t or not? I've seen some translation is using impor/ekspor but the glossary is using it with t, so I'm not so sure which one to use

About this one (not sure if already clarified or not in this PR), we can check and discuss it here: #337 (comment)

The official pair from KBBI are impor and ekspor.

@mazipan said to use impor/ekspor, and I've updated it yesterday

@aroyan aroyan changed the title translation for importing and exporting components docs: translation for importing and exporting components Apr 28, 2023
@mhaidarhanif
Copy link
Collaborator

mhaidarhanif commented Apr 28, 2023 •
edited
Loading

@mazipan said to use impor/ekspor, and I've updated it yesterday

Yes impor/ekspor has been confirmed.

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@mhaidarhanif
Copy link
Collaborator

Let's be ready to merge.

@mhaidarhanif
Copy link
Collaborator

@r17x your requested changes have been resolved.

@mhaidarhanif mhaidarhanif dismissed r17x’s stale review April 28, 2023 14:37

All requested changes have been resolved.

@mhaidarhanif mhaidarhanif merged commit 4fc8bdd into reactjs:main Apr 28, 2023
@mhaidarhanif mhaidarhanif changed the title docs: translation for importing and exporting components New Indonesian translation: importing and exporting components Apr 28, 2023
r17x added a commit that referenced this pull request May 8, 2023
@aroyan @r17x
@mazipan @mhaidarhanif
New Indonesian translation: importing and exporting components (#345)
42594ed 
Co-authored-by: RiN <hi@rin.rocks>
Co-authored-by: Irfan Maulana <mazipanneh@gmail.com>
Co-authored-by: M Haidar Hanif <git@mhaidarhanif.com>
@aroyan aroyan deleted the docs/translation/learn branch August 2, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mazipan mazipan mazipan left review comments

@mhaidarhanif mhaidarhanif mhaidarhanif approved these changes

@r17x r17x r17x left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Importing and Exporting Components
4 participants
@aroyan @mhaidarhanif @mazipan @r17x