Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the data instance is not being passed to base classes. #26

Merged
merged 2 commits into from
Jun 19, 2019

Conversation

glennawatson
Copy link
Contributor

  • Pass the instance to base classes in constructors.
  • Allow parallel tests again.
  • Update the analyzers and fix concerns that come up.
  • Use stream writers, due to the multiple writes.

- Allow parallel tests again.
- Update the analyzers and fix concerns that come up.
- Use stream writers, due to the multiple writes.
@glennawatson glennawatson requested a review from a team June 19, 2019 06:45
@codecov
Copy link

codecov bot commented Jun 19, 2019

Codecov Report

Merging #26 into master will increase coverage by 1.12%.
The diff coverage is 66.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage   82.64%   83.77%   +1.12%     
==========================================
  Files          41       41              
  Lines        1170     1177       +7     
  Branches      221      242      +21     
==========================================
+ Hits          967      986      +19     
+ Misses        176      163      -13     
- Partials       27       28       +1
Impacted Files Coverage Δ
...Generation/Resolvers/EventNamespaceResolverBase.cs 100% <ø> (+79.48%) ⬆️
src/Pharmacist.Core/NuGet/NuGetFrameworkHelper.cs 95.18% <0%> (-2.36%) ⬇️
.../Extractors/PlatformExtractors/NetFrameworkBase.cs 100% <100%> (ø) ⬆️
...re/Generation/Generators/InstanceEventGenerator.cs 100% <100%> (ø) ⬆️
...neration/Resolvers/PublicEventNamespaceResolver.cs 100% <100%> (ø) ⬆️
...ist.Core/Extractors/PlatformExtractors/Winforms.cs 100% <100%> (ø) ⬆️
...armacist.Core/Extractors/PlatformExtractors/WPF.cs 100% <100%> (ø) ⬆️
src/Pharmacist.Core/NuGet/NuGetPackageHelper.cs 94.11% <50%> (-1.54%) ⬇️
...rc/Pharmacist.Core/ObservablesForEventGenerator.cs 72% <59.18%> (-16.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 047c03f...544910d. Read the comment docs.

@glennawatson glennawatson merged commit d2220b7 into master Jun 19, 2019
@delete-merged-branch delete-merged-branch bot deleted the glennawatson-fix-data-passed branch June 19, 2019 08:11
@lock lock bot locked and limited conversation to collaborators Sep 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant