Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: className doesn't work with tabPanel #420

Merged
merged 1 commit into from
Oct 13, 2021
Merged

fix: className doesn't work with tabPanel #420

merged 1 commit into from
Oct 13, 2021

Conversation

ttys026
Copy link
Contributor

@ttys026 ttys026 commented Aug 27, 2021

No description provided.

@vercel
Copy link

vercel bot commented Aug 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/tabs/9mXzLYdLV6fCvjPw8PjF2EdaAAjE
✅ Preview: https://tabs-git-fork-ttys026-master-react-component.vercel.app

@afc163 afc163 merged commit a412700 into react-component:master Oct 13, 2021
@hzura
Copy link

hzura commented Nov 25, 2021

@ttys026 @afc163 这个PR会导致同一个className同时作用在TabPane和TabNode上,而此前只会作用在TabPane上,很可能导致版本升级后样式出现错乱。这是符合预期的吗?

@afc163
Copy link
Member

afc163 commented Nov 25, 2021

@hzura 看上去确实是不应该放到 tab 上。

afc163 added a commit that referenced this pull request Nov 26, 2021
afc163 added a commit that referenced this pull request Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants