Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Not break if tabBarExtraContent is empty object #411

Merged
merged 1 commit into from
Jul 29, 2021
Merged

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jul 29, 2021

No description provided.

@vercel
Copy link

vercel bot commented Jul 29, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/tabs/2hwDZhVfTU1caYB1ws1v8GBCnuaB
✅ Preview: https://tabs-git-fix-extra-react-component.vercel.app

@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #411 (eae3ee3) into master (0e9f8ab) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #411   +/-   ##
=======================================
  Coverage   99.45%   99.45%           
=======================================
  Files          13       13           
  Lines         551      554    +3     
  Branches      140      139    -1     
=======================================
+ Hits          548      551    +3     
  Misses          3        3           
Impacted Files Coverage Δ
src/TabNavList/index.tsx 99.47% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e9f8ab...eae3ee3. Read the comment docs.

@zombieJ zombieJ merged commit 48afe60 into master Jul 29, 2021
@zombieJ zombieJ deleted the fix-extra branch July 29, 2021 03:31
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jul 29, 2021

This pull request introduces 1 alert when merging eae3ee3 into 0e9f8ab - view on LGTM.com

new alerts:

  • 1 for Useless conditional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant