Add tests for bug jashkenas#4290, fail to make them pass

rdeforest · Dec 5, 2016 · 336f1bf · 336f1bf
1 parent 67b025e
commit 336f1bf
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 3 deletions.
diff --git a/lib/coffee-script/command.js b/lib/coffee-script/command.js
diff --git a/lib/coffee-script/grammar.js b/lib/coffee-script/grammar.js
diff --git a/src/grammar.coffee b/src/grammar.coffee
@@ -248,6 +248,7 @@ grammar =
   # The list of parameters that a function accepts can be of any length.
   ParamList: [
     o '',                                       -> []
+    o 'Comment'
     o 'Param',                                  -> [$1]
     o 'ParamList , Param',                      -> $1.concat $3
     o 'ParamList OptComma TERMINATOR Param',    -> $1.concat $4
@@ -477,6 +478,7 @@ grammar =
   # (i.e. comma-separated expressions). Newlines work as well.
   ArgList: [
     o 'Arg',                                              -> [$1]
+    o 'Comment'                                           -> []
     o 'ArgList , Arg',                                    -> $1.concat $3
     o 'ArgList OptComma TERMINATOR Arg',                  -> $1.concat $4
     o 'INDENT ArgList OptComma OUTDENT',                  -> $2

diff --git a/test/comments.coffee b/test/comments.coffee
@@ -431,3 +431,12 @@ test "#3761: Multiline comment at end of an object", ->
 test "#4375: UTF-8 characters in comments", ->
   # 智に働けば角が立つ、情に掉させば流される。
   ok yes
+
+test "#4290: Block comment in array", ->
+  anArray = [ ### ### ]
+
+test "#4290: Block comment in function call args", ->
+  -> fn( ### ### )
+
+test "#4290: Block comment in function expression params", ->
+  fn = ( ### ### ) ->