BREAKING: Bye bye, batches #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we can access the completion context, we actually _have_ an env we can use to copy the request ref, so we can avoid having to serialize it to binary. While we're at it, clean up the submit function a little.
rbino
force-pushed
the
feat/bye-bye-batches
branch
from
f22538f to
1750996
Compare
Remove the input batch concept (i.e. a NIF resource that preallocated a binary with a fixed size to accomodate a certain number of Events) and replace it with a more idiomatic API. I'll probably write a blogpost on this, but in short: - I was lured into this trying to replicate the Java client mechanism described in "Writing High-Performance Clients for Tigerbeetle" - ...but the API is excessively clunky when used in a language with immutable data - ...and it doesn't actually make things faster in the Elixir case - ...and it adds lots of code both on the Elixir and the Zig side So, just use an idiomatic API for Elixir, passing lists of structs as input. I've run the benchmark before and after and the throughput is fundamentally the same (when measuring the same thing, the old benchmark actually "cheated" a little).
rbino
force-pushed
the
feat/bye-bye-batches
branch
from
1750996 to
13dbabb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the input batch concept (i.e. a NIF resource that preallocated a binary with a fixed size to accomodate a certain number of Events) and replace it with a more idiomatic API.
I'll probably write a blogpost on this, but in short:
So, just use an idiomatic API for Elixir, passing lists of structs as input.
I've run the benchmark before and after and the throughput is fundamentally the same (when measuring the same thing, the old benchmark actually "cheated" a little).