Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gofumports url #18

Closed
Davincible opened this issue Aug 5, 2021 · 4 comments
Closed

Gofumports url #18

Davincible opened this issue Aug 5, 2021 · 4 comments

Comments

@Davincible
Copy link
Contributor

go.nvim/lua/go/install.lua

Line 6 in 7872cc3

gofumports = "mvdan.cc/gofumpt",

This line should be:
gofumports = "mvdan.cc/gofumpt/gofumports",
@Davincible
Copy link
Contributor Author

Oh just noticed my other issue about it being depricated lol. But I guess as long as it is looking for gofumports the url should be as above to install it properly

@ray-x
Copy link
Owner

ray-x commented Aug 5, 2021

The README.md of gofumpt shows

GO111MODULE=on go get mvdan.cc/gofumpt

Are both urls work?

@Darkclainer
Copy link
Contributor

gofumports is deprecated and I assume is no longer supported: mvdan/gofumpt#75

Also it working perfectly from gopls and users without gopls should be fine by using gofumpt + goimports.

Maybe reference to gofumports should be removed from README and documentation to no cause confusion.

ray-x added a commit that referenced this issue Sep 25, 2021
@ray-x
remove gofumport from go.nvim #18
7feb745
@ray-x
Copy link
Owner

ray-x commented Sep 25, 2021

gofumport removed

@ray-x ray-x closed this as completed Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ray-x @Darkclainer @Davincible