[core] [wip attempt] No noexcept constructor to fix windows build

[dayshah]

Why are these changes needed?

Trying to fix windows build with no noexcept constructor.

Related issue number

Checks

• I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
• I've run scripts/format.sh to lint the changes in this PR.
• I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've added any new APIs to the API Reference. For example, if I added a
    method in Tune, I've added it in doc/source/tune/api/ under the
    corresponding .rst file.
• I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
• Testing Strategy
  • Unit tests
  • Release tests
  • This PR is not tested :(

[dayshah]

https://en.cppreference.com/w/cpp/language/union
If a union contains a non-static data member with a non-trivial default constructor, the default constructor of the union is deleted by default unless a variant member of the union has a default member initializer .
https://stackoverflow.com/questions/70428563/unions-default-constructor-is-implicitly-deleted

msvc error complains that StatusOr doesn't have it's default constructor because of data_. Maybe this explicitly initializing will work?

[dentiny]

Well it's still failing

[dayshah]

Well it's still failing

same here, memory_store_test is working, gcs_worker_manager is failing

[dayshah]

Well it's still failing

same here, memory_store_test is working, gcs_worker_manager is failing

oh i was not on top of the latest commit