fix: add logs for transaction failing #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ex1st0r
reviewed
Apr 12, 2024
| async wait(): Promise<any> { return Promise.reject("asd") } | ||
| } | ||
|
|
||
| jest.mock("@rarible/sdk-transaction", () => { // replace with actual path |
There was a problem hiding this comment.
This mock brokes some tests
Need to move this mock to target test or move whole test to separated file
| : responsePromise) | ||
|
|
||
| returnedPromis.then(async (tx) => { | ||
| if (tx?.transaction?.constructor.name === "BlockchainEthereumTransaction") { |
There was a problem hiding this comment.
Need to improve instance checking
| await remoteLogger.raw(dataContainer.getErrorData(wrappedError || err, { method: replaceMethodPart(callable.name, "wait") })) | ||
| } | ||
| } | ||
| }).catch((_) => {}) |
There was a problem hiding this comment.
Remove argument if it's not needed (lint fix)
| } | ||
| } catch (e) { } | ||
|
|
||
| await delay(1000) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.