Initial attempt to upgrade to scala3 rc1 #64
Conversation
yurique
changed the title
yurique
force-pushed
the
initial-attempt-to-upgrade-to-scala3-M3
branch
from
7ef6a4d to
f44bc13
Compare
| lazy val root = | ||
| project.in(file(".")) | ||
| .aggregate(domtypes.js, domtypes.jvm) | ||
| .settings(noPublish) |
There was a problem hiding this comment.
I guess it's not possible to configure noPublish from release.sbt? Not sure which way is better, it just seems everything else release-related is there now.
There was a problem hiding this comment.
yeah, can't refer a lazy val defined in a different sbt file
| "-Ywarn-unused:params", | ||
| "-Wunused:explicits" | ||
| ))), | ||
| scalacOptions in (Compile, doc) ~= (_.filter(_.startsWith("-Xplugin"))), |
There was a problem hiding this comment.
What / why are you filtering for here?
There was a problem hiding this comment.
it's because of this: typelevel/sbt-tpolecat#36
I later changed this to explicitly filtering out the offensive scalac options, but forgot to change here: https://github.com/raquo/Airstream/pull/68/files#diff-5634c415cd8c8504fdb973a3ed092300b43c4b8fc1e184f7249eb29a55511f91R24-R39
|
|
||
| inThisBuild(Seq( | ||
| name := "Scala DOM Types", | ||
| normalizedName := "domtypes", |
There was a problem hiding this comment.
Where does the new config take normalizedName from? I'd prefer for it to be explicit.
There was a problem hiding this comment.
sbt says it's "not used by any other settings/tasks", so it doesn't affect anything
| .aggregate(domtypes.js, domtypes.jvm) | ||
| .settings(noPublish) | ||
| .settings( | ||
| name := "Scala DOM Types" |
There was a problem hiding this comment.
This used to be in ThisBuild / name, right? I'm sbt-challenged, is this the same, or if not, what's the difference?
There was a problem hiding this comment.
With a single module (root) the result is the same (if there were modules, ThisBuils / name would set the same name for all of them). In this case, I don't really have a strong opinion (just did it as it is in Airstream/Laminar).
Co-authored-by: Scalavision <scalavision@gmail.com>
Co-authored-by: Scalavision <scalavision@gmail.com>
based on top of scalavisions changes: https://github.com/scalavision/scala-js-dom/compare/upgrade-scala3-M3...yurique:upgrade-scala3-M3?expand=1