Skip to content
This repository was archived by the owner on Feb 12, 2022. It is now read-only.

Return to URI slash instead of OS file separator #674

Merged
merged 1 commit into from
Nov 14, 2019

Conversation

mauriarroqui
Copy link
Contributor

@mauriarroqui mauriarroqui commented Nov 13, 2019

We need to rollback (#666) to URI format slash, that change broke raml 08 parsing on Windows as it uses backslash. In RAML, paths are unix-like (forward slash). APIKIT needed that change to resolve includes inside XSD files in which other XSD files can be included in a file path way (not URI). However, that change didn’t resolve their issue completely, it is still failing.

@jstoiko jstoiko requested a review from jpbelang November 13, 2019 22:33
@jpbelang
Copy link
Collaborator

Could you check #675 ? If it isn't what you mean, I'll merge your rollback.

@mauriarroqui
Copy link
Contributor Author

mauriarroqui commented Nov 14, 2019

I guess it is not that fix. i.e param path in getParentPath(String path) is relative path (I don't know if a relative path could came as param) in a windows machine like a/b/c.raml, it is not an URI, so it will look for last index of \, and will return -1.

@jpbelang jpbelang merged commit b5fd847 into raml-org:0.8.x Nov 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants