remove gas setting for eth_call request #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
We noticed an issue after deploying the GSN contracts on Amoy testnet and running our relayer. Gas predictions were returning with an odd error that we assumed at first was a misconfiguration.
It turns out there is some very specific geth/bor functionality when you send a
eth_callrequest withgasPriceset. see ethereum/go-ethereum#21108 for more details.Inside the GSN common library there is a call being sent this way:
https://github.com/opengsn/gsn/blob/v3.0.0-beta.3/packages/common/src/ContractInteractor.ts#L952-L953
This combination was causing all relayed transactions on Amoy to return the error above.
Fix
Since it's in a dependency of the relayer this PR makes a copy of the bug-triggering function into
RelayServer.tsand removes thegasPricefrom the call. Relaying transacations work after this change.