Removes null links from pagination #2294
Conversation
according to the json-api spec (json-schema file), links must not be null
|
@langalex Thanks for the issue The behavior of AMS is actually correct. You linked to document links. If you scroll down to https://jsonapi.org/format/#fetching-pagination you'll see that null is allowed. In addition, the schema is not authoritative. |
|
Ok sorry about that. I ran the responses of my tails API tests against the schema and that failed, so I guess the schema is wrong in this case. Do you have any idea how much sense it would make to try to get it updated? |
|
Never mind. I'll do some proper research before asking any more uninformed questions. |
|
@langalex No need to be hard on yourself. You're asking the same questions I and many others have asked :) |
|
Turns out the schema does in fact not allow null links even though it probably should. But there's already an issue for that |
Purpose
Become (more) compliant with JSON-API.
Changes
Remove null links from pagination.
Caveats
None.
Related GitHub issues
None.
Additional helpful information
I ran the pagination links generated by active_model_serializers against the JSON-API spec, and it turns out links must not be null. See also the schema. Only strings and objects are allowed.