Include namespace when looking up serializer for parent class if one … #2242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf4
reviewed
Feb 14, 2018
| def test_serializer_inherited_serializer_with_namespace | ||
| serializer = ActiveModel::Serializer.serializer_for(@my_profile, namespace: SerializerNamespace) | ||
| assert_equal SerializerNamespace::ProfileSerializer, serializer | ||
| end |
There was a problem hiding this comment.
Yes. The reason is that when looking up the serializer for superclass, in #get_serializer_for the namespace is not passed along in the method call.
|
This is a long-standing well-known issue, and previous pull requests to fix it were ignored 😞 Hope you have better luck getting this one merged! |
|
@wasifhossain Done, thanks! |
|
closing this in favor of #2172 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…was passed
Purpose
To consider namespace, if one was passed, when looking up serializer for parent of a subclass.
Changes
Pass namespace along when looking up serializer for superclass of resource.
Caveats
Related GitHub issues
Additional helpful information