Fix CI on 0-10-stable #2181
Merged
Fix CI on 0-10-stable #2181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf4
commented
Aug 29, 2017
.travis.yml
Outdated
| - { rvm: jruby-head, env: RAILS_VERSION=master } | ||
| - { rvm: 2.1, env: RAILS_VERSION=5.0 } | ||
| - { rvm: jruby-9.1.5.0, env: RAILS_VERSION=5.0 } | ||
| - { rvm: jruby-head, env: RAILS_VERSION=5.0 } |
There was a problem hiding this comment.
this is just for readability
bf4
commented
Aug 29, 2017
Gemfile
Outdated
| gem 'railties', gem_version | ||
| gem 'activesupport', gem_version | ||
| gem 'activemodel', gem_version | ||
| gem 'actionpack', gem_version | ||
| gem 'activerecord', gem_version, group: :test | ||
| end | ||
|
|
||
| if RUBY_VERSION < '2.1' | ||
| gem 'nokogiri', '< 1.7' | ||
| end |
There was a problem hiding this comment.
✂️ we don't test against lower than ruby 2.1
bf4
commented
Aug 29, 2017
Gemfile
Outdated
| @@ -47,7 +53,7 @@ group :test do | |||
| gem 'codeclimate-test-reporter', require: false | |||
| gem 'm', '~> 1.5' | |||
| gem 'pry', '~> 0.10' | |||
| gem 'pry-byebug', '~> 3.4', platform: :ruby | |||
| gem 'pry-byebug', '>= 3.4', platform: :ruby | |||
There was a problem hiding this comment.
Fetching gem metadata from https://rubygems.org/...........
Fetching version metadata from https://rubygems.org/..
Fetching dependency metadata from https://rubygems.org/.
Resolving dependencies...
byebug-9.1.0 requires ruby version >= 2.2.0, which is incompatible with the
current version, ruby 2.1.5p273
Merged
bf4
force-pushed
the
fix_ci
branch
2 times, most recently
from
054f2ed to
9c63464
Compare
``` Resolving dependencies... byebug-9.1.0 requires ruby version >= 2.2.0, which is incompatible with the current version, ruby 2.1.10p492 ```
Update appveyor Ruby to 2.3 to work around: ``` Gem::InstallError: nokogiri requires Ruby version < 2.5, >= 2.2. An error occurred while installing nokogiri (1.8.0), and Bundler cannot continue. Make sure that `gem install nokogiri -v '1.8.0'` succeeds before bundling. ``` and not 2.4 since: https://ci.appveyor.com/project/bf4/active-model-serializers/build/1.0.1052-fix_ci/job/0q3itabsnvnxr83u ``` nokogiri-1.6.8.1-x86-mingw32 requires ruby version < 2.4, which is incompatible with the current version, ruby 2.4.1p111 ```
(For Rails5) In Rails5, checking for Rails::Railtie is better
rails-42d09f6b49da/railties/lib/rails/application.rb ```ruby def secret_key_base if Rails.env.test? || Rails.env.development? Digest::MD5.hexdigest self.class.name ```
jruby/activerecord-jdbc-adapter#708 ``` uninitialized constant ActiveRecord::ConnectionAdapters::Column::Format ``` see https://travis-ci.org/rails-api/active_model_serializers/jobs/277112008
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix CI
I'll accept PRs into the fix_ci branch if anyone wants to help
Changes
A bunch because it's been broken for a while.
Each change is isolated in a commit, though, so should be easy enough to follow
Caveats
Related GitHub issues
Additional helpful information
e.g. in
#2179