Add helpful testing gems #1913
Add helpful testing gems #1913
Conversation
|
@richmolj, thanks for your PR! By analyzing the annotation information on this pull request, we identified @bf4, @steveklabnik and @beauby to be potential reviewers |
richmolj
force-pushed
the
test_gems
branch
4 times, most recently
from
869631e to
785c4a1
Compare
| @@ -9,6 +9,12 @@ | |||
| STDERR.puts 'Running without SimpleCov' | |||
| end | |||
|
|
|||
| begin | |||
There was a problem hiding this comment.
If you just require pry, it will load all pry plugins. This will lead to less churn if/when we add more pry configurations. I won't block if this doesn't seem interesting to you. It would require adding pry to the gemfile, then we could remove the rescue here since pry is all platforms
There was a problem hiding this comment.
sure ill give that a shot
| @@ -45,6 +45,8 @@ group :test do | |||
| gem 'sqlite3', platform: (@windows_platforms + [:ruby]) | |||
| gem 'activerecord-jdbcsqlite3-adapter', platform: :jruby | |||
| gem 'codeclimate-test-reporter', require: false | |||
| gem 'm', '~> 1.5' | |||
| gem 'pry', '~> 0.10' | |||
There was a problem hiding this comment.
I mean, put in pry-byebug as well, just limit it to valid platforms
There was a problem hiding this comment.
oh, duh, yes of course. updated, thanks
There was a problem hiding this comment.
what advantage does adding pry provide? I thought pry-byebug included it.
| @@ -9,6 +9,7 @@ | |||
| STDERR.puts 'Running without SimpleCov' | |||
| end | |||
|
|
|||
| require 'pry' | |||
There was a problem hiding this comment.
shouldn't this be require 'pry-byebug'?
There was a problem hiding this comment.
This was actually a great suggestion by @bf4 - if you require 'pry' it will load any pry plugins for you. So if you are non-MRI you will only get pry (works across rubies), if you are MRI you get pry-byebug as well (both specified in Gemfile).
Adds gems m (run minitest by line numbers like rspec) and pry-byebug (for binding.pry support).
Addresses #1911 (comment)