Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

env CAPTURE_STDERR=false lets devs see hard failures #1178

Merged

Conversation

bf4
Copy link
Member

@bf4 bf4 commented Sep 18, 2015

I noticed that if I had runtime errors, I wouldn't see the stacktrace
or exception message.

Turns out, this is something about the at_exit resolution of io
capturing between capture_errors and Minitest.

I couldn't figure out how to modify the io for Minitest without a lot of
code, so this is a safety valve for devs :) :(

MiniTest 4

  • MiniTest::Unit.output = my_thing

Minitest 5

  • Make a plugin can makes a reporter that holds onto a special io

@bf4
Copy link
Member Author

bf4 commented Sep 18, 2015

@jfelchner :)

@jfelchner
Copy link
Contributor

👍 😀

@NullVoxPopuli
Copy link
Contributor

👍

NullVoxPopuli added a commit that referenced this pull request Sep 18, 2015
env CAPTURE_STDERR=false lets devs see hard failures
@NullVoxPopuli NullVoxPopuli merged commit 7cf0e93 into rails-api:master Sep 18, 2015
@bf4 bf4 deleted the opt_out_capturing_stderr_warnings branch December 21, 2015 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants