-
Notifications
You must be signed in to change notification settings - Fork 866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NotificationService: Missing IEquatable<T> Implementation in NotificationMessage #1288
Comments
Hi @quicksln , Yes, sure! We accept pull requests! |
quicksln
added a commit
to quicksln/radzen-blazor-notification
that referenced
this issue
Dec 15, 2023
…on in NotificationMessage
Pull request has been created. Please verify if everything is according to your development standards. |
quicksln
added a commit
to quicksln/radzen-blazor-notification
that referenced
this issue
Dec 18, 2023
…on in NotificationMessage - fix for GetHashCode
enchev
pushed a commit
that referenced
this issue
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The Notification Service relies on distributing messages from an observable collection:
ObservableCollection<NotificationMessage> Messages
The Notification Service includes two 'Notify' methods that check whether the collection contains a specific instance of NotificationMessage and add messages to the collection.
However, it does not function correctly because NotificationMessage does not implement IEquatable.
This interface implementation is necessary to determine if specific object instances are equal when using the List.Contains method.
To Reproduce
Steps to reproduce the behavior:
Run unit test :
Screenshots

Desktop (please complete the following information):
• OS: all
• Browser: [edge, chrome, safari
• Version: 4.22.1
Additional context
If my assumption is correct, I’ll be happy to fix it.
The text was updated successfully, but these errors were encountered: