Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak: Removes connect button overlay transparency #306

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

dhedey
Copy link
Contributor

@dhedey dhedey commented Dec 20, 2024

(Replaces #303 which was against my fork before I had write permissions)

Overview

There were a few issues with the connect button theming:

  • The transparency was causing nasty contrast issues when overlaying dark/light mode on different backgrounds.
  • Some of the UI controls and text had low contrast against the background

This PR attempts to fix this by:

  • Removing transparency of the the background, and choosing a suitable static colour to make all the UI and text have acceptable contrast
  • Tweaked some of the internal colours very slightly, so that all UI elements are visible and have contrast, and distinguishable hover states

Screenshots below...

Other thoughts / outstanding questions

  • Should the light mode background be lighter?
    • But if you do this, you get contrast issues with the buttons (which current tint to white on hover)
    • A workaround would be to have the buttons start white (like the RadMatt card) and tint darker on hover. But this seemed like too big of a change to make without input from design.
  • Why is the Sharing tab shorter than the Requests tab?
  • If a dApp doesn't configure a dApp name, then we say Sharing with which looks ... weird?

Light Mode

Before on black/white background

Screenshot 2024-12-19 at 19 15 55 Screenshot 2024-12-19 at 19 16 13 Screenshot 2024-12-19 at 19 17 12 Screenshot 2024-12-19 at 19 16 56
  • The buttons looked washed out / hard to distinguish on a white background (the designs only covered slightly grey backgrounds)
  • It is unusable on a black background

After (background independent)

Screenshot 2024-12-19 at 19 23 13 Screenshot 2024-12-19 at 19 23 25 Screenshot 2024-12-19 at 19 22 20 Screenshot 2024-12-19 at 19 22 33

Dark Mode

Before on black/white background

Screenshot 2024-12-19 at 19 13 55 Screenshot 2024-12-19 at 19 14 12 Screenshot 2024-12-19 at 18 01 20 Screenshot 2024-12-19 at 19 17 56
  • The buttons are hard to distinguish on a black background (the designs only covered slightly grey backgrounds)
  • It looks fine on a white background

After (background independent)

Screenshot 2024-12-19 at 19 20 42 Screenshot 2024-12-19 at 19 21 03 Screenshot 2024-12-19 at 19 21 36 Screenshot 2024-12-19 at 19 21 23

The transparency was causing nasty contrast issues when
overlaying dark/light mode on different backgrounds.

Instead, the background colours have been fixed, and some of
the internal colours tweaked slightly, so that all UI elements are
visible and have contrast, and distinguishable hover states.
@dhedey dhedey changed the title Tweak/connect button transparency tweak: Removes connect button overlay transparency Dec 20, 2024
@dhedey dhedey changed the base branch from main to develop December 20, 2024 13:48
@dawidsowardx dawidsowardx self-requested a review January 14, 2025 14:43
@dawidsowardx dawidsowardx merged commit 1872775 into develop Jan 14, 2025
19 of 22 checks passed
Copy link

🎉 This PR is included in version 2.2.1-dev.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 2.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants