Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/olympia end state api changes #51

Merged
merged 4 commits into from
Aug 31, 2023

Conversation

shambupujar
Copy link
Contributor

#Update CLI to support Zabanet ( rcnet-v3)

Description

For rcnet-v3, following properties were renamed
Properties genesis.olympia.node_core_api_* renamed to genesis.olympia.node_end_state_api_* and similarly their corresponding env variables (RADIXDLT_GENESIS_OLYMPIA_NODE_CORE_API_* -> RADIXDLT_GENESIS_OLYMPIA_NODE_END_STATE_API_*})

Update the nodecli code and tests to support zabanet node and the seed node

@shambupujar shambupujar requested review from a user and balda-rdx August 31, 2023 13:03
@github-actions
Copy link

github-actions bot commented Aug 31, 2023

Test Results

37 tests  ±0   31 ✔️ ±0   24s ⏱️ +4s
  1 suites ±0     6 💤 ±0 
  1 files   ±0     0 ±0 

Results for commit 58fc2f1. ± Comparison against base commit b017a7b.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 31, 2023

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
3380 2193 65% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
node-runner-cli/commands/dockercommand.py 46% 🟢
node-runner-cli/tests/test_gateway_setup.py 90% 🟢
node-runner-cli/utils/Network.py 93% 🟢
node-runner-cli/utils/Prompts.py 69% 🟢
TOTAL 74% 🟢

updated for commit: 58fc2f1 by action🐍

@shambupujar shambupujar merged commit 3011c62 into main Aug 31, 2023
@ghost ghost deleted the fix/olympia_end_state_api_changes branch September 18, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant