enabling the option to run core without nginx #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
ghost
previously approved these changes
Aug 18, 2023
ghost
dismissed
their stale review
Seems like the core test is failing. Can you try to replicate why the connection to /system/health was not able to be established?
balda-rdx
added a commit
that referenced
this pull request
Aug 22, 2023
* adding the option to use the docker compose plugin * updating the python core client version * installing version 2023.7.23 of pipenv * fixing syntax * using the method from DockerCompose to run the down command * avoiding to fail on error when checking the docker compose plugin * using shell=true to run docker-compose commands * enabling the option to run core without nginx (#45) * enabling the option to run core without nginx * updating the conditions for adding the nginx volume * using tag to reference the python core dep * updating the syntax to install core-client * installing pipenv==2023.7.23 * adding the option to use the docker compose plugin * using the method from DockerCompose to run the down command * avoiding to fail on error when checking the docker compose plugin * using shell=true to run docker-compose commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.