rabbit_channel: Ignore DOWN message from monitored process if it exited normally #13336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed normally [Why] It happens in CI from time to time and it was crashing the channel process. There is always a `channel.close` method pending in the channel mailbox. [How] For now, log something and ignore the DOWN message. The channel will exit after handling the pending `channel.close` method anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
It happens in CI from time to time and it was crashing the channel process. There is always a
channel.closemethod pending in the channel mailbox.How
For now, log something and ignore the DOWN message. The channel will exit after handling the pending
channel.closemethod anyway.