fix: hardcoded test failing in the CI #448
Merged
+19
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #448 +/- ##
==========================================
- Coverage 75.46% 75.45% -0.01%
==========================================
Files 64 64
Lines 14108 14107 -1
Branches 14108 14107 -1
==========================================
- Hits 10647 10645 -2
- Misses 2099 2100 +1
Partials 1362 1362
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
chungquantin
approved these changes
Mar 10, 2025
chungquantin
added a commit
that referenced
this pull request
Mar 10, 2025
* fix: remove hardcoded node name in test * fix: bump versions in Cargo.lock to fix deny * chore: ignore unmantained vulnerability * fix: cargo deny unmaintained crate --------- Co-authored-by: chungquantin <56880684+chungquantin@users.noreply.github.com>
chungquantin
added a commit
that referenced
this pull request
Mar 10, 2025
* fix: remove hardcoded node name in test * fix: bump versions in Cargo.lock to fix deny * chore: ignore unmantained vulnerability * fix: cargo deny unmaintained crate --------- Co-authored-by: chungquantin <56880684+chungquantin@users.noreply.github.com>
chungquantin
added a commit
that referenced
this pull request
Mar 10, 2025
* fix: remove hardcoded node name in test * fix: bump versions in Cargo.lock to fix deny * chore: ignore unmantained vulnerability * fix: cargo deny unmaintained crate --------- Co-authored-by: chungquantin <56880684+chungquantin@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the updates in the
pop-noderelease, one test was failing in the CI (https://github.com/r0gue-io/pop-cli/actions/runs/13666853327/job/38359250240?pr=435) due to a hardcoded value for the node name,pop-devnetwhich is no longer applicable in the new release. The hardcoded value has been removed.Additionally, this update fixes cargo deny in the CI by bumping dependency versions. It was automatic done by the dependabot #447. But deny was still failing so had to add a vulnerability in the
deny.toml.The PR introduces two new vulnerability dependency: