Fix test output when compared to .Rout.save files #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For tests that compare the output. Closes #88.
For correctly interleaved stdout and stderr.
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
==========================================
- Coverage 80.13% 77.44% -2.69%
==========================================
Files 17 17
Lines 755 807 +52
==========================================
+ Hits 605 625 +20
- Misses 150 182 +32
Continue to review full report at Codecov.
|
gaborcsardi
force-pushed
the
fix/test-output
branch
4 times, most recently
from
a80e781 to
17bae37
Compare
Try to install processx manually from GH, for now...
gaborcsardi
force-pushed
the
fix/test-output
branch
from
17bae37 to
1387e03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #88.
It is not great on Windows, because there the stdout/stderr mixup matters more. I'll open another issue for that.
Edit: now also closes #96.