New logo sizes for realfavicongenerator

[Bisaloo]

This may seem like a duplicate of #2801 and it is indeed the manifestation of the same issue but another occurrence, that requires another fix.

pkgdown tries to serve a 48x48 png favicon but since RealFaviconGenerator/core@e5c10ba, it looks like this has been replaced by 96x96 png.

You can replicate this with both the API and the online version.

I can submit a PR to fix this and use 96x96 in the short-term.

[Bisaloo]

In the long-term, I wonder whether the trade-off of using realfavicongenerator is a net benefit.

Yes, it saves pkgdown some local dependency (pkgdown was previously dependent on magick & the imagemagick system library) but as far as I can tell, changes are not tracked as thoroughly as they would for a potential R package dependency.

For example, https://realfavicongenerator.net/ has a change log page advertised in its navbar but it hasn't been updated since 2018! https://realfavicongenerator.net/change-log

Releases on GitHub do not contain release notes either: https://github.com/RealFaviconGenerator/core/tags.

It makes catching changes like this up to users that will encounter bugs when they could in theory be caught during the development cycle of pkgdown.

(I posted this as a separate comment because you may prefer to defer this discussion to later in its own issue. Feel free to split off if comment if that's the case.)

[jayhesselberth]

Prior to these recent changes, the generator output was stable for several years. Hopefully this is the last change for a while.